core: Block predecessors #3235
Merged
core: Block predecessors #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
==========================================
- Coverage 90.07% 89.90% -0.17%
==========================================
Files 438 440 +2
Lines 54881 55344 +463
Branches 8523 8635 +112
==========================================
+ Hits 49433 49758 +325
- Misses 4065 4159 +94
- Partials 1383 1427 +44 ☔ View full report in Codecov by Sentry. |
math-fehr
approved these changes
Oct 2, 2024
| @@ -1756,6 +1779,50 @@ def __next__(self): | |||
| return next_block | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class OpSuccessors(Sequence[Block]): | |||
superlopuh
reviewed
Oct 2, 2024
superlopuh
reviewed
Oct 2, 2024
superlopuh
approved these changes
Oct 2, 2024
Co-authored-by: Sasha Lopoukhine <[email protected]>
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
Adds a list of uses to blocks, and adds a function to get the predecessors of a block. --------- Co-authored-by: Sasha Lopoukhine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of uses to blocks, and adds a function to get the predecessors of a block.
I'm slightly unsure about the code re-use in this PR. It feels slightly wrong to use the
Useclass for both operand usage and successor usage, though the data is the same. I'm also unsure if I should have attempted to unifyOpOperandsandOpSuccessorsunder a single interface, as they are very similar.