Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Add CSL dsd canonicalisation #3208

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Sep 23, 2024

Folds:

  • GetMemDsdOp followed by IncrementDsdOffsetOp, SetDsdLengthOp, SetDsdStrideOp
  • Chained IncrementDsdOffsetOp, SetDsdLengthOp, SetDsdStrideOp of the same op type

@n-io n-io added the transformations Changes or adds a transformatio label Sep 23, 2024
@n-io n-io self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (5d9837e) to head (595376a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3208    +/-   ##
========================================
  Coverage   90.04%   90.04%            
========================================
  Files         432      433     +1     
  Lines       54454    54568   +114     
  Branches     8448     8465    +17     
========================================
+ Hits        49031    49135   +104     
- Misses       4056     4060     +4     
- Partials     1367     1373     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io marked this pull request as ready for review September 23, 2024 16:40
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed synchronously, with @n-io. All looks good 👍

@n-io n-io merged commit 5349938 into main Sep 25, 2024
14 checks passed
@n-io n-io deleted the nicolai/canonicalise-dsds branch September 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants