Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (csl) Add direction type #3136

Merged
merged 3 commits into from
Sep 2, 2024
Merged

dialects: (csl) Add direction type #3136

merged 3 commits into from
Sep 2, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Sep 2, 2024

Adding direction type to csl

@n-io n-io added dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable labels Sep 2, 2024
@n-io n-io requested a review from dk949 September 2, 2024 15:43
@n-io n-io self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (8a70781) to head (a70febb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   89.94%   89.93%   -0.01%     
==========================================
  Files         425      425              
  Lines       53591    53617      +26     
  Branches     8303     8309       +6     
==========================================
+ Hits        48200    48223      +23     
- Misses       4049     4052       +3     
  Partials     1342     1342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus the nit (which you can feel free to ignore) it LGTM

xdsl/backend/csl/print_csl.py Outdated Show resolved Hide resolved
@n-io n-io merged commit ba215da into main Sep 2, 2024
14 checks passed
@n-io n-io deleted the nicolai/csl-direction branch September 2, 2024 16:00
@AntonLydike
Copy link
Collaborator

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants