Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Update dialects with SameSize IRDL options. #3070

Merged
merged 12 commits into from
Aug 20, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 20, 2024

Welp. After properly checking llvm-project, a few operations use this trait. BUT if we eliminate operations using this traits while having NO corresponding variadic construct, only memref.extract_strided_metadata actually needs this..
If anyone has time to go do something about it on MLIR's side, we could actually lift that complexity out 👼

Fixes #3064

Stacked on:

@PapyChacal PapyChacal added dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable labels Aug 20, 2024
@PapyChacal PapyChacal self-assigned this Aug 20, 2024
@PapyChacal PapyChacal changed the base branch from main to emilien/samesize August 20, 2024 12:29
@PapyChacal PapyChacal linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (bc1529e) to head (0851c47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3070   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files         418      418           
  Lines       52764    52764           
  Branches     8175     8175           
=======================================
+ Hits        47425    47428    +3     
+ Misses       4015     4012    -3     
  Partials     1324     1324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review August 20, 2024 12:41
Base automatically changed from emilien/samesize to main August 20, 2024 15:28
@PapyChacal PapyChacal merged commit 4824d02 into main Aug 20, 2024
9 checks passed
@PapyChacal PapyChacal deleted the emilien/dialects-samesize branch August 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: We need more variadic inference for compatibility
2 participants