-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: Update dialects with SameSize IRDL options. #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
added
dialects
Changes on the dialects
minor
For minor PRs, easy and quick to review, quickly mergeable
labels
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 418 418
Lines 52764 52764
Branches 8175 8175
=======================================
+ Hits 47425 47428 +3
+ Misses 4015 4012 -3
Partials 1324 1324 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welp. After properly checking llvm-project, a few operations use this trait. BUT if we eliminate operations using this traits while having NO corresponding variadic construct, only
memref.extract_strided_metadata
actually needs this..If anyone has time to go do something about it on MLIR's side, we could actually lift that complexity out 👼
Fixes #3064
Stacked on: