Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (stim) initialise dialect #3042

Merged
merged 15 commits into from
Aug 30, 2024
Merged

dialects: (stim) initialise dialect #3042

merged 15 commits into from
Aug 30, 2024

Conversation

kimxworrall
Copy link
Collaborator

Initial commit to add a dialect stim to represent Stim.

Stim is a tool for simulating quantum stabilizer circuits, particularly for quantum error correction (QEC) circuits.

Find the github library for Stim here

@kimxworrall kimxworrall self-assigned this Aug 15, 2024
@alexarice alexarice self-requested a review August 15, 2024 15:33
@alexarice alexarice added the dialects Changes on the dialects label Aug 15, 2024
xdsl/dialects/stim.py Outdated Show resolved Hide resolved
xdsl/dialects/stim.py Outdated Show resolved Hide resolved
xdsl/dialects/stim.py Outdated Show resolved Hide resolved
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@superlopuh
Copy link
Member

Oh except that the tests don't pass :)

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (1e488d7) to head (a63cb4d).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
+ Coverage   89.89%   89.91%   +0.01%     
==========================================
  Files         419      425       +6     
  Lines       53017    53379     +362     
  Branches     8221     8267      +46     
==========================================
+ Hits        47660    47995     +335     
- Misses       4028     4047      +19     
- Partials     1329     1337       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, is this currently blocked on #3106 ?

@kimxworrall
Copy link
Collaborator Author

Just to check, is this currently blocked on #3106 ?

Not to my knowledge

@superlopuh
Copy link
Member

This suddenly has way more things, was that intentional?

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the printable things for printing to the format that stim expects?

@kimxworrall
Copy link
Collaborator Author

Are the printable things for printing to the format that stim expects?

Yes, I'll add a comment about that in the current pr - the next one will be a parser from stim.

@kimxworrall kimxworrall merged commit c198365 into main Aug 30, 2024
14 checks passed
@kimxworrall kimxworrall deleted the kim/stim/dialect branch August 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants