Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: (stablehlo) add ir generation from jaxpr #3038

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

shreya-um
Copy link
Collaborator

This will let us create an xDSL module from a function jitted with JAX.

@shreya-um shreya-um added the frontend Forcefully embedding xDSL into Python label Aug 15, 2024
@shreya-um shreya-um self-assigned this Aug 15, 2024
@shreya-um shreya-um changed the title frontend: (stablehlo) add ir generation from jaxpr [WIP] frontend: (stablehlo) add ir generation from jaxpr Aug 15, 2024
@superlopuh superlopuh changed the base branch from main to sasha/jax/dependency August 15, 2024 12:05
Base automatically changed from sasha/jax/dependency to main August 15, 2024 12:59
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (4423038) to head (89525f2).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3038      +/-   ##
==========================================
+ Coverage   89.86%   89.90%   +0.03%     
==========================================
  Files         415      419       +4     
  Lines       52078    53006     +928     
  Branches     8048     8219     +171     
==========================================
+ Hits        46799    47653     +854     
- Misses       3984     4025      +41     
- Partials     1295     1328      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Feel free to mark the PR as "ready for review", and remove the [WIP] in the PR title

@shreya-um shreya-um changed the title [WIP] frontend: (stablehlo) add ir generation from jaxpr frontend: (stablehlo) add ir generation from jaxpr Aug 19, 2024
@shreya-um shreya-um marked this pull request as ready for review August 21, 2024 12:11
for _ in module_ast.jaxpr.eqns:
raise NotImplementedError("jax equation not implemented")

if inputVars == outputVars:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just assert this is true for this PR, and change it in the next one?

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! feel free to merge once you've made the suggested changes

@shreya-um shreya-um merged commit d7d30e7 into main Aug 26, 2024
14 checks passed
@shreya-um shreya-um deleted the shreya/jax/jaxpr-stablehlo branch August 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Forcefully embedding xDSL into Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants