-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: (stablehlo) add ir generation from jaxpr #3038
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3038 +/- ##
==========================================
+ Coverage 89.86% 89.90% +0.03%
==========================================
Files 415 419 +4
Lines 52078 53006 +928
Branches 8048 8219 +171
==========================================
+ Hits 46799 47653 +854
- Misses 3984 4025 +41
- Partials 1295 1328 +33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Feel free to mark the PR as "ready for review", and remove the [WIP]
in the PR title
… shreya/jax/jaxpr-stablehlo
xdsl/frontend/jaxpr/__init__.py
Outdated
for _ in module_ast.jaxpr.eqns: | ||
raise NotImplementedError("jax equation not implemented") | ||
|
||
if inputVars == outputVars: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just assert this is true for this PR, and change it in the next one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! feel free to merge once you've made the suggested changes
This will let us create an xDSL module from a function jitted with JAX.