-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: remove mentions of black formatter #3032
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 413 413
Lines 51852 51852
Branches 8006 8006
=======================================
+ Hits 46592 46594 +2
+ Misses 3970 3969 -1
+ Partials 1290 1289 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find any usages of the word black in the repository so looks good
@@ -105,12 +113,6 @@ pyright: | |||
xdsl-stubgen | |||
pyright $(shell git diff --staged --name-only -- '*.py') | |||
|
|||
# run black on all files currently staged | |||
black: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth having a "make ruff" replacement for this or is it just unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially changed this to make format
but then I thought that was silly since it's the same number of characters and doesn't seem particularly useful.
Co-authored-by: Alex Rice <[email protected]>
A bit of cleanup.
make black