Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove mentions of black formatter #3032

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

superlopuh
Copy link
Member

A bit of cleanup.

  1. exclude ruff transition from git blame
  2. remove make black
  3. clean up comments
  4. Makefile now also has 88 column width, because why not
  5. Add jupyter notebooks and type stubs to ruff formatted file list

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (996f649) to head (449afd4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3032   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         413      413           
  Lines       51852    51852           
  Branches     8006     8006           
=======================================
+ Hits        46592    46594    +2     
+ Misses       3970     3969    -1     
+ Partials     1290     1289    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find any usages of the word black in the repository so looks good

README.md Outdated Show resolved Hide resolved
@@ -105,12 +113,6 @@ pyright:
xdsl-stubgen
pyright $(shell git diff --staged --name-only -- '*.py')

# run black on all files currently staged
black:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth having a "make ruff" replacement for this or is it just unnecessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially changed this to make format but then I thought that was silly since it's the same number of characters and doesn't seem particularly useful.

Co-authored-by: Alex Rice <[email protected]>
@superlopuh superlopuh merged commit e1f68b5 into main Aug 14, 2024
9 checks passed
@superlopuh superlopuh deleted the sasha/ruff/no-black branch August 14, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants