dialects: (stablehlo) add elementwise add, sub, mul #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
zero9178,
georgebisbas,
PapyChacal and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 413 413
Lines 51852 51871 +19
Branches 8006 8010 +4
=======================================
+ Hits 46592 46610 +18
- Misses 3970 3972 +2
+ Partials 1290 1289 -1 ☔ View full report in Codecov by Sentry. |
alexarice
reviewed
Aug 14, 2024
| @@ -1,8 +0,0 @@ | |||
| // RUN: xdsl-opt %s --parsing-diagnostics --verify-diagnostics --split-input-file | filecheck %s | |||
There was a problem hiding this comment.
Would be good it this could have been git mved but not necessary
| class ElementwiseBinaryOperation(IRDLOperation, abc.ABC): | ||
| # TODO: Remove this constraint for complex types. | ||
| T = Annotated[AnyTensorType, ConstraintVar("T")] | ||
|
|
There was a problem hiding this comment.
Should these have some verification that the inputs are "numeric"
There was a problem hiding this comment.
Eventually we'll make these constrained to the values that the original stablehlo dialect supports, I don't think it's critical right now.
nope |
alexarice
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reorganizes the test.
CC @efferifick