core: helpers for IRDL construct type access. #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sasha Lopoukhine <[email protected]>
Co-authored-by: Sasha Lopoukhine <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
=======================================
Coverage 89.85% 89.86%
=======================================
Files 412 412
Lines 51823 51834 +11
Branches 8033 8004 -29
=======================================
+ Hits 46565 46579 +14
+ Misses 3967 3966 -1
+ Partials 1291 1289 -2 ☔ View full report in Codecov by Sentry. |
n-io
reviewed
Aug 13, 2024
| class VarOpResult(tuple[OpResult, ...]): | ||
| @property | ||
| def types(self): | ||
| return tuple(r.type for r in self) |
There was a problem hiding this comment.
this is great if this doesn't need an or [[]]
There was a problem hiding this comment.
This wasn't actually needed where you used it 🙂 Happy to discuss it in chat if you're curious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement simple type access helpers, but for IRDL