CI: use ruff to format xdsl #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
AntonLydike,
georgebisbas,
math-fehr,
PapyChacal and
webmiche
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
superlopuh
commented
Aug 13, 2024
.pre-commit-config.yaml
Outdated
superlopuh
commented
Aug 13, 2024
pyproject.toml
Outdated
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
- Coverage 89.85% 89.85% -0.01%
==========================================
Files 412 412
Lines 51816 51816
Branches 8064 8064
==========================================
- Hits 46559 46558 -1
Misses 3967 3967
- Partials 1290 1291 +1 ☔ View full report in Codecov by Sentry. |
PapyChacal
reviewed
Aug 13, 2024
Comment on lines
-2
to
+32
| Signed numbers are stored as Two's complement, meaning that the highest bit is used as | ||
| the sign. Here's a table of values for a three-bit two's complement integer type: | ||
|
|
||
| |------|----------|--------| | ||
| | bits | unsigned | signed | | ||
| |------|----------|--------| | ||
| | 000 | 0 | +0 | | ||
| | 001 | 1 | +1 | | ||
| | 010 | 2 | +2 | | ||
| | 011 | 3 | +3 | | ||
| | 100 | 4 | -4 | | ||
| | 101 | 5 | -3 | | ||
| | 110 | 6 | -2 | | ||
| | 111 | 7 | -1 | | ||
| |------|----------|--------| | ||
|
|
||
| https://en.wikipedia.org/wiki/Two%27s_complement | ||
|
|
||
| We follow LLVM and MLIR in having a concept of signless integers: | ||
|
|
||
| https://mlir.llvm.org/docs/Rationale/Rationale/#integer-signedness-semantics | ||
|
|
||
| The main idea is to not have the signedness be a property of the type of the value, | ||
| and rather be a property of the operation. That means that a signless value can be | ||
| interpreted as either a signed or unsigned value at runtime, depending on the | ||
| operation that acts on it. | ||
|
|
||
| During interpretation, this gets a little tricky, as the same bit pattern can be | ||
| interpreted as two runtime values, meaning that comparing signless values is a little | ||
| involved. For example, a signless value of 5 is equal to a signless value of -3, since | ||
| their bit representations are the same. | ||
| Signed numbers are stored as Two's complement, meaning that the highest bit is used as | ||
| the sign. Here's a table of values for a three-bit two's complement integer type: | ||
|
|
||
| |------|----------|--------| | ||
| | bits | unsigned | signed | | ||
| |------|----------|--------| | ||
| | 000 | 0 | +0 | | ||
| | 001 | 1 | +1 | | ||
| | 010 | 2 | +2 | | ||
| | 011 | 3 | +3 | | ||
| | 100 | 4 | -4 | | ||
| | 101 | 5 | -3 | | ||
| | 110 | 6 | -2 | | ||
| | 111 | 7 | -1 | | ||
| |------|----------|--------| | ||
|
|
||
| https://en.wikipedia.org/wiki/Two%27s_complement | ||
|
|
||
| We follow LLVM and MLIR in having a concept of signless integers: | ||
|
|
||
| https://mlir.llvm.org/docs/Rationale/Rationale/#integer-signedness-semantics | ||
|
|
||
| The main idea is to not have the signedness be a property of the type of the value, | ||
| and rather be a property of the operation. That means that a signless value can be | ||
| interpreted as either a signed or unsigned value at runtime, depending on the | ||
| operation that acts on it. | ||
|
|
||
| During interpretation, this gets a little tricky, as the same bit pattern can be | ||
| interpreted as two runtime values, meaning that comparing signless values is a little | ||
| involved. For example, a signless value of 5 is equal to a signless value of -3, since | ||
| their bit representations are the same. |
PapyChacal
approved these changes
Aug 13, 2024
|
The line length change in that PR was to move it to linting only, meaning that the formatter is still at black's default 88 cols |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs in
0.04son my computer.The Ruff format is designed to be a drop-in replacement for black. As you see, most of the diff is adding a new line at the start of every class, which seems like a good change. I'll comment on the config files with changes for easier reviewing.
Note stacked PR.