Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: lint jupyter notebooks using ruff #3010

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented Aug 10, 2024

resolves #1273

@superlopuh superlopuh added the CI Continuous Integration label Aug 10, 2024
@superlopuh superlopuh self-assigned this Aug 10, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Base automatically changed from sasha/ruff/update-precommit to main August 10, 2024 12:03
@superlopuh superlopuh force-pushed the sasha/ci/ruff-jupyter-notebooks branch from 5733561 to 67fbbd5 Compare August 10, 2024 12:07
@superlopuh superlopuh changed the base branch from main to sasha/ruff/update-lint-toml August 10, 2024 12:07
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (6ba2b15) to head (b0a20cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3010   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         411      411           
  Lines       51674    51674           
  Branches     8034     8034           
=======================================
  Hits        46419    46419           
  Misses       3970     3970           
  Partials     1285     1285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from sasha/ruff/update-lint-toml to main August 11, 2024 23:13
@superlopuh superlopuh merged commit dcd8628 into main Aug 11, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/ci/ruff-jupyter-notebooks branch August 11, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Add support of Jupyter Notebook to Ruff
2 participants