Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(transform, minor): stencil-to-csl-stencil retain interesting compute structure property #2926

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Jul 22, 2024

Minor fix to retain the imbalanced tree compute structure.

Before the transform, the compute structure was of the form:
(((a + b) + c) + d)

After the transform, the compute structure was of the form:
(a + b) + (c + d)

As the imbalanced tree structure (first) is preferable for reference semantics and easier to translate, this pass should retain this property.

@n-io n-io added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Jul 22, 2024
@n-io n-io requested review from AntonLydike and dk949 July 22, 2024 15:48
@n-io n-io self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (0424d07) to head (639adcb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2926   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         404      404           
  Lines       50486    50480    -6     
  Branches     7798     7795    -3     
=======================================
- Hits        45390    45386    -4     
+ Misses       3865     3864    -1     
+ Partials     1231     1230    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io merged commit a676ad0 into main Jul 23, 2024
10 checks passed
@n-io n-io deleted the nicolai/csl-stencil-compute-structure-fix branch July 23, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants