Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add FixedbitWidthType Interface #2904

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

jorendumoulin
Copy link
Collaborator

These functions to determine the bit/byte width of an element are useful in many places. I think I have them implemented in a couple of different places myself, so I think this abstraction is quite useful in this regard. The functions were now defined in a pass, I simply moved them over.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (2f24609) to head (90f853c).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
- Coverage   89.90%   89.90%   -0.01%     
==========================================
  Files         403      404       +1     
  Lines       50422    50481      +59     
  Branches     7787     7795       +8     
==========================================
+ Hits        45333    45383      +50     
- Misses       3862     3866       +4     
- Partials     1227     1232       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorendumoulin jorendumoulin changed the title core: Add BitWidthType Interface core: Add FixedbitWidthType Interface Jul 22, 2024
@jorendumoulin jorendumoulin merged commit 4e0afef into main Jul 22, 2024
10 checks passed
@jorendumoulin jorendumoulin deleted the joren/bitwidth-abstraction branch July 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants