-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Add FixedbitWidthType Interface #2904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
==========================================
- Coverage 89.90% 89.90% -0.01%
==========================================
Files 403 404 +1
Lines 50422 50481 +59
Branches 7787 7795 +8
==========================================
+ Hits 45333 45383 +50
- Misses 3862 3866 +4
- Partials 1227 1232 +5 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Jul 19, 2024
superlopuh
reviewed
Jul 19, 2024
superlopuh
reviewed
Jul 19, 2024
superlopuh
reviewed
Jul 19, 2024
superlopuh
approved these changes
Jul 19, 2024
jorendumoulin
changed the title
core: Add BitWidthType Interface
core: Add FixedbitWidthType Interface
Jul 22, 2024
superlopuh
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions to determine the bit/byte width of an element are useful in many places. I think I have them implemented in a couple of different places myself, so I think this abstraction is quite useful in this regard. The functions were now defined in a pass, I simply moved them over.