Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(transform): csl_wrapper program module init #2891

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Jul 16, 2024

This PR initialises the program_module of a CSL wrapper. Computes additional known values to remove any dependency on utils.csl.

Minor fixes:

  • Add utility function get_param_value to csl_wrapper.ModuleOp
  • small fix to get_apply on csl_stencil.AccessOp to work for both csl.Apply or csl_stencil.Apply

@n-io n-io added the transformations Changes or adds a transformatio label Jul 16, 2024
@n-io n-io requested review from AntonLydike and dk949 July 16, 2024 16:04
@n-io n-io self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (2d67e7c) to head (3352de2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2891      +/-   ##
==========================================
- Coverage   89.90%   89.88%   -0.03%     
==========================================
  Files         407      407              
  Lines       50864    50890      +26     
  Branches     7873     7879       +6     
==========================================
+ Hits        45729    45741      +12     
- Misses       3894     3908      +14     
  Partials     1241     1241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io requested a review from dk949 July 26, 2024 15:10
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally ok merging this, but I would like to hear @AntonLydike 's opining on get_param_value

@n-io n-io merged commit 912a579 into main Jul 26, 2024
10 checks passed
@n-io n-io deleted the nicolai/csl-wrapper-program-module-init branch July 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants