-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(transform): csl_wrapper program module init #2891
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
- Coverage 89.90% 89.88% -0.03%
==========================================
Files 407 407
Lines 50864 50890 +26
Branches 7873 7879 +6
==========================================
+ Hits 45729 45741 +12
- Misses 3894 3908 +14
Partials 1241 1241 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally ok merging this, but I would like to hear @AntonLydike 's opining on get_param_value
This PR initialises the program_module of a CSL wrapper. Computes additional known values to remove any dependency on
utils.csl
.Minor fixes:
get_param_value
to csl_wrapper.ModuleOpget_apply
on csl_stencil.AccessOp to work for bothcsl.Apply
orcsl_stencil.Apply