-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (riscv_snitch) Add f32 mul, add, pack from Snitch packed SIMD extension #2872
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
========================================
Coverage 89.86% 89.86%
========================================
Files 396 397 +1
Lines 49829 49976 +147
Branches 7683 7716 +33
========================================
+ Hits 44780 44913 +133
- Misses 3838 3846 +8
- Partials 1211 1217 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just one nitpick about the use of CHECK-LABEL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add assembly printing tests?
This PR adds a small set of operations to
riscv_snitch
directly mapping on top of the Snitch custom packed SIMD ISA. Further ops are going to need operand constraints to be correctly register allocated.