Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Implement block dominance #2790

Merged
merged 12 commits into from
Jun 28, 2024
Merged

core: Implement block dominance #2790

merged 12 commits into from
Jun 28, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Jun 27, 2024

Thought I wanted to use the concept, realized I do not right now, but figured I might as well open the PR.

Free bikeshedding:

I like rethinking vocabulary that I find a bit outdatedly heavy on the tone, like how we finally call the default branch main rather than master. Anyone has ideas on a name sounding right but lighter than "dominance"?

@PapyChacal PapyChacal added the core xDSL core (ir, textual format, ...) label Jun 27, 2024
@PapyChacal PapyChacal self-assigned this Jun 27, 2024
@PapyChacal PapyChacal marked this pull request as ready for review June 27, 2024 14:40
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (4b44800) to head (b5d5d1f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
- Coverage   89.81%   89.81%   -0.01%     
==========================================
  Files         391      393       +2     
  Lines       48567    48619      +52     
  Branches     7436     7448      +12     
==========================================
+ Hits        43620    43665      +45     
- Misses       3780     3783       +3     
- Partials     1167     1171       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot ;)

xdsl/irdl/dominance.py Outdated Show resolved Hide resolved
xdsl/irdl/dominance.py Outdated Show resolved Hide resolved
xdsl/irdl/dominance.py Outdated Show resolved Hide resolved
xdsl/irdl/dominance.py Outdated Show resolved Hide resolved
@PapyChacal PapyChacal merged commit bac07d1 into main Jun 28, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/dominance branch June 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants