core: preserve name hints when replacing ops with multiple results #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
approved these changes
May 29, 2024
Comment on lines
-17
to
+22
| // CHECK-NEXT: %o1, %o1_1 = stencil.apply(%one = %t : !stencil.temp<?xf64>) -> (!stencil.temp<?xf64>, !stencil.temp<?xf64>) { | ||
| // CHECK-NEXT: %o1, %o2 = stencil.apply(%one = %t : !stencil.temp<?xf64>) -> (!stencil.temp<?xf64>, !stencil.temp<?xf64>) { | ||
| // CHECK-NEXT: %0 = stencil.access %one[0] : !stencil.temp<?xf64> | ||
| // CHECK-NEXT: stencil.return %0, %0 : f64, f64 | ||
| // CHECK-NEXT: } | ||
| // CHECK-NEXT: stencil.store %o1 to %of1 ([0] : [64]) : !stencil.temp<?xf64> to !stencil.field<[0,64]xf64> | ||
| // CHECK-NEXT: stencil.store %o1_1 to %of2 ([0] : [64]) : !stencil.temp<?xf64> to !stencil.field<[0,64]xf64> | ||
| // CHECK-NEXT: stencil.store %o2 to %of2 ([0] : [64]) : !stencil.temp<?xf64> to !stencil.field<[0,64]xf64> |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
=======================================
Coverage 89.62% 89.62%
=======================================
Files 361 361
Lines 46245 46248 +3
Branches 6988 6990 +2
=======================================
+ Hits 41446 41449 +3
Misses 3724 3724
Partials 1075 1075 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.