core: Add BitEnumAttribute
#2617
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
==========================================
- Coverage 89.85% 89.84% -0.01%
==========================================
Files 413 413
Lines 51852 51888 +36
Branches 8006 8011 +5
==========================================
+ Hits 46592 46620 +28
- Misses 3970 3975 +5
- Partials 1290 1293 +3 ☔ View full report in Codecov by Sentry. |
|
Ah, @zero9178, now it's just the formatting failing, should be easy enough to get working locally for you, then should be good to open up for review when you're ready |
AntonLydike
changed the title
BitEnumAttributeBitEnumAttribute
math-fehr
force-pushed
the
zero9178/bitenumattribute
branch
from
8b06f3f
to
1391b8b
Compare
|
Currently taking over, I'm splitting this PR in multiple ones as well |
|
@math-fehr what's the latest on this? |
|
Sorry about this. I merged part of it (the parsing for enums) but now I don't have time anymore to continue it in the next month. |
jorendumoulin
force-pushed
the
zero9178/bitenumattribute
branch
2 times, most recently
from
c66c49b
to
6c0a1a9
Compare
jorendumoulin
force-pushed
the
zero9178/bitenumattribute
branch
from
d94f49d
to
147d745
Compare
jorendumoulin
changed the title
BitEnumAttributeBitEnumAttribute
|
I rebased this, fixed some things and added tests and documentation. I think it's ready for review! |
xdsl/ir/core.py
Outdated
|
|
||
| cls.enum_type = enum_type | ||
| super().__init__(tuple(cast(set[EnumType], flags_))) |
There was a problem hiding this comment.
Is the cast here necessary? it seems that all the branches above set it to the expected type
There was a problem hiding this comment.
Hmm, the branches do set it to StrEnum, set[StrEnum] does not equal set[EnumType]
Expression of type "set[StrEnum] is imcompatible with return type "set[EnumType]"
Even though EnumType = TypeVar('EnumType', bound=StrEnum)
This is because cls.enumtype is StrEnum. I cannot hovewer make this EnumType, as it is illegal to have a typevar as a classvariable
| if value is None: | ||
| return None | ||
|
|
||
| return {cast(type[EnumType], cls.enum_type)(value)} |
The
BitEnumAttributeis meant to be the equivalent ofBitEnumAttrin MLIR: https://github.com/llvm/llvm-project/blob/e67f2cc3fc38cec2041cfb197ac4688ed3d16e7e/mlir/include/mlir/IR/EnumAttr.td#L266It allows defining an attribute which in abstract is a set of flag values where each flag value is defined within an enum.
The base class is meant to be easy to use like
EnumAttributeand automatically define suitable parsers and printers.For an in-tree user that is converted by this PR see
FastMathAttrin the LLVM and arith dialects.