Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (seq) Add CompRegOp #2404

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

Moxinilian
Copy link
Contributor

This op allows modeling registers. This is for now a very basic implementation which only partially matches the CompRegOp upstream. But it should be enough for many practical uses already!

@Moxinilian Moxinilian added enhancement New feature or request dialects Changes on the dialects labels Mar 31, 2024
@Moxinilian Moxinilian self-assigned this Mar 31, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (df1c825) to head (a7642fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         346      346           
  Lines       41418    41430   +12     
  Branches     6175     6176    +1     
=======================================
+ Hits        37144    37156   +12     
  Misses       3372     3372           
  Partials      902      902           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucjaulmes
Copy link
Collaborator

lucjaulmes commented Apr 1, 2024

I think maybe you could add the optional $powerOnValue operand? Otherwise LGTM 🚀

Optional attributes inner_sym and name will need #2407.

(Though name is a bit of a weird one, it seems to be inferred from “the SSA name of the operation’s first result” and to only be printed if not matching with the SSA name. I think just adding it as an optional attribute down the line should be enough?)

@Moxinilian
Copy link
Contributor Author

Moxinilian commented Apr 1, 2024

I think maybe you could add the optional $powerOnValue operand? Otherwise LGTM 🚀

It's a bit silly but adding the power on value triggers a bug in the assembly format thing that is a bit over my head to attempt to fix. Perhaps we can do without for now?

@lucjaulmes
Copy link
Collaborator

Sure. Maybe file a bug about the double-optionals? We’ll have to revisit compregop anyway.

Copy link
Collaborator

@luisacicolini luisacicolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Moxinilian
Copy link
Contributor Author

#2413

@Moxinilian Moxinilian merged commit 855d4dd into xdslproject:main Apr 3, 2024
10 checks passed
@Moxinilian Moxinilian deleted the compreg branch April 4, 2024 15:12
lucjaulmes added a commit that referenced this pull request Apr 12, 2024
Now #2448 and #2407 are in we can finally complete what was left out of
#2404:
- an optional attribute `inner_sym` 
- the second optional operand `powerOn`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants