-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (seq) Add CompRegOp #2404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 346 346
Lines 41418 41430 +12
Branches 6175 6176 +1
=======================================
+ Hits 37144 37156 +12
Misses 3372 3372
Partials 902 902 ☔ View full report in Codecov by Sentry. |
I think maybe you could add the optional Optional attributes (Though |
It's a bit silly but adding the power on value triggers a bug in the assembly format thing that is a bit over my head to attempt to fix. Perhaps we can do without for now? |
Sure. Maybe file a bug about the double-optionals? We’ll have to revisit compregop anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This op allows modeling registers. This is for now a very basic implementation which only partially matches the CompRegOp upstream. But it should be enough for many practical uses already!