Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriting: Extend TypeConversionPattern annotation #2332

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Moxinilian
Copy link
Contributor

I found it was a little bit odd that this decorator did not allow the option for conversion to still be skipped even though the type matches the expected one. This change should be benign I expect?

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (1ea23dd) to head (2102200).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2332   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         335      335           
  Lines       40311    40318    +7     
  Branches     6027     6027           
=======================================
+ Hits        36092    36099    +7     
  Misses       3347     3347           
  Partials      872      872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math-fehr math-fehr merged commit f8db528 into xdslproject:main Mar 12, 2024
10 checks passed
@superlopuh superlopuh added transformations Changes or adds a transformatio rewriting changes on xDSL rewrite engine and removed transformations Changes or adds a transformatio labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewriting changes on xDSL rewrite engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants