dialects: linalg minor fixes #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `doc` and `library_call` are properties - The parenthesis around output types are mandatory in custom syntax if multiple types are present.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
==========================================
- Coverage 89.53% 89.51% -0.02%
==========================================
Files 329 329
Lines 39443 39446 +3
Branches 5904 5905 +1
==========================================
- Hits 35314 35309 -5
- Misses 3270 3275 +5
- Partials 859 862 +3 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Mar 6, 2024
| @@ -96,8 +96,8 @@ class Generic(IRDLOperation): | |||
| # Trait attributes | |||
| indexing_maps: ArrayAttr[AffineMapAttr] = prop_def(ArrayAttr[AffineMapAttr]) | |||
| iterator_types: ArrayAttr[IteratorTypeAttr] = prop_def(ArrayAttr[IteratorTypeAttr]) | |||
| doc: StringAttr | None = opt_attr_def(StringAttr) | |||
| library_call: StringAttr | None = opt_attr_def(StringAttr) | |||
| doc: StringAttr | None = opt_prop_def(StringAttr) | |||
There was a problem hiding this comment.
do you think it would be too much of a detour to implement default properties before merging this?
There was a problem hiding this comment.
I really want to - and soon! Though this is actually a sensitive fix: MLIR interop is currently broken without it. Can I have your approval to merge this frustrating opt_prop_def so it's functional first? We'll get rid of those eventually!
superlopuh
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docandlibrary_callare properties