Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dialects): add tensor.reshape #2240

Merged
merged 6 commits into from
Feb 27, 2024
Merged

(dialects): add tensor.reshape #2240

merged 6 commits into from
Feb 27, 2024

Conversation

kayode-gif
Copy link
Collaborator

@kayode-gif kayode-gif commented Feb 27, 2024

resolves #2233

@kayode-gif kayode-gif added the dialects Changes on the dialects label Feb 27, 2024
@kayode-gif kayode-gif self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.47%. Comparing base (59550be) to head (13c0e1f).

Files Patch % Lines
xdsl/dialects/tensor.py 96.72% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   89.46%   89.47%   +0.01%     
==========================================
  Files         328      328              
  Lines       39175    39234      +59     
  Branches     5805     5811       +6     
==========================================
+ Hits        35046    35103      +57     
- Misses       3322     3323       +1     
- Partials      807      808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayode-gif
Copy link
Collaborator Author

kayode-gif commented Feb 27, 2024

@superlopuh facing issues with writing invalid tests on op, does't seem to like how its parsed

my verify_ method was syntactically incorrect

@kayode-gif kayode-gif changed the title add tensor-reshape (dialects): add tensor.reshape Feb 27, 2024
@kayode-gif kayode-gif marked this pull request as ready for review February 27, 2024 15:46
@kayode-gif kayode-gif merged commit 0f45834 into main Feb 27, 2024
10 checks passed
@kayode-gif kayode-gif deleted the oke/add-tensor-reshape branch February 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dialects): add tensor.reshape
2 participants