dialects: (LLVM) Fix use of attributes dict when dialect specifies prop_def #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm.extractvalue llvm.insertvalue
ed741
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
=======================================
Coverage 90.17% 90.17%
=======================================
Files 305 305
Lines 37041 37041
Branches 5515 5515
=======================================
Hits 33402 33402
Misses 2860 2860
Partials 779 779 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes use of attributes dict when dialect specifies prop_def for:
llvm.extractvalue
llvm.insertvalue
Seems like a bug left over from #1874