Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: (riscv_debug) add implementation for riscv_debug.printf #1998

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

superlopuh
Copy link
Member

Reopening accidental merge of #1991

@superlopuh superlopuh added the interpreter xDSL Interpreter label Jan 22, 2024
@superlopuh superlopuh self-assigned this Jan 22, 2024
@compor
Copy link
Collaborator

compor commented Jan 22, 2024

sorry for that, it is usually good practice to mention if something is stack on the PR message.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62e23e8) 89.96% compared to head (deee126) 89.97%.
Report is 2 commits behind head on sasha/riscv_debug/printf.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           sasha/riscv_debug/printf    #1998      +/-   ##
============================================================
+ Coverage                     89.96%   89.97%   +0.01%     
============================================================
  Files                           288      290       +2     
  Lines                         35797    35830      +33     
  Branches                       5270     5271       +1     
============================================================
+ Hits                          32204    32239      +35     
+ Misses                         2834     2830       -4     
- Partials                        759      761       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from sasha/riscv_debug/printf to main January 22, 2024 15:06
@superlopuh superlopuh merged commit e8477c4 into main Jan 22, 2024
9 checks passed
@superlopuh superlopuh deleted the sasha/riscv_debug/interp branch January 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter xDSL Interpreter
Projects
Development

Successfully merging this pull request may close these issues.

3 participants