Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Refresh Affine, add interoperability test. #1981

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

PapyChacal
Copy link
Collaborator

Refresh affine:

  • affine.for:
    • Rename (lower|upper)_bound -> (lower|upper)BoundMap
    • Split variadics arguments in 3 variadic arguments 🎉
  • affine.if:
    For some reason affine.if's condition is not a property.

Add interoperability test.

@PapyChacal PapyChacal added the dialects Changes on the dialects label Jan 16, 2024
@PapyChacal PapyChacal self-assigned this Jan 16, 2024
@PapyChacal PapyChacal marked this pull request as ready for review January 16, 2024 12:41
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3d1c19f) 89.84% compared to head (4cdd547) 89.83%.

Files Patch % Lines
xdsl/dialects/affine.py 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1981      +/-   ##
==========================================
- Coverage   89.84%   89.83%   -0.01%     
==========================================
  Files         284      284              
  Lines       35473    35478       +5     
  Branches     5227     5228       +1     
==========================================
+ Hits        31869    31872       +3     
- Misses       2836     2837       +1     
- Partials      768      769       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@PapyChacal PapyChacal merged commit 8f21d97 into main Jan 16, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/affine-interop branch January 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants