interpreter: (linalg) allow scalar params for linalg generic #1932
Conversation
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
PapyChacal,
webmiche and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1932 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 279 279
Lines 34087 34100 +13
Branches 5078 5080 +2
=======================================
+ Hits 30491 30505 +14
Misses 2868 2868
+ Partials 728 727 -1 ☔ View full report in Codecov by Sentry. |
| @@ -91,3 +91,49 @@ def test_linalg_generic(): | |||
| interpreter.run_op(op, (a, b, c)) | |||
|
|
|||
| assert c.data == [1, 4, 9, 16, 25, 36] | |||
|
|
|||
|
|
|||
| def test_linalg_generic_scalar(): | |||
There was a problem hiding this comment.
Out of curiosity, why doing the test here rather than in an MLIR file?
I find MLIR files overall more readable, and making more sense since they test exactly what we want.
There was a problem hiding this comment.
TBH mostly because I already had this file lying around. I'll take a look into converting this to filecheck.
There was a problem hiding this comment.
I usually add python files for individual ops but the generic one is a bit awkward to test for individually, easier to set up more of an integration style test
There was a problem hiding this comment.
Actually let's merge this and I create a task to do this later? Feels less time-sensitive than some other things I'd like to move on to in the short term.
No description provided.