dialect: (riscv_snitch) prettify frep custom syntax #1791
Conversation
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
adutilleul
| def print(self, printer: Printer) -> None: | ||
| printer.print_string(" ") | ||
| printer.print_ssa_value(self.max_rep) | ||
| if self.stagger_count.data and self.stagger_mask.data: |
There was a problem hiding this comment.
AFAIK we don't actually ahve any use cases for these values, so might as well not print them by default
There was a problem hiding this comment.
This got me thinking if having a zero mask and an actual stagger count does anything or if it's even legal.
There was a problem hiding this comment.
I bet it's legal and probably does nothing, a problem for the future :)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
- Coverage 88.92% 88.91% -0.02%
==========================================
Files 260 260
Lines 32088 32102 +14
Branches 4733 4736 +3
==========================================
+ Hits 28535 28542 +7
- Misses 2861 2866 +5
- Partials 692 694 +2 ☔ View full report in Codecov by Sentry. |
| def print(self, printer: Printer) -> None: | ||
| printer.print_string(" ") | ||
| printer.print_ssa_value(self.max_rep) | ||
| if self.stagger_count.data and self.stagger_mask.data: |
There was a problem hiding this comment.
This got me thinking if having a zero mask and an actual stagger count does anything or if it's even legal.
|
This seems to be good-to-go. Should we merge it? |
|
Thank you for the reminder |
No description provided.