Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: (riscv) Add canonicalization pattern for AddImmediateConstant #1695

Merged
merged 1 commit into from
Oct 24, 2023
Merged

backend: (riscv) Add canonicalization pattern for AddImmediateConstant #1695

merged 1 commit into from
Oct 24, 2023

Conversation

superlopuh
Copy link
Member

Also throw in some Pure() annotations

@superlopuh superlopuh added the backend Compiler backend in xDSL label Oct 24, 2023
@superlopuh superlopuh self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
xdsl/dialects/riscv.py 91.22% <100.00%> (+<0.01%) ⬆️
xdsl/transforms/canonicalization_patterns/riscv.py 98.63% <100.00%> (+0.05%) ⬆️

📢 Thoughts on this report? Let us know!.

@compor compor changed the title backend: (riscv) add canonicalization pattern for AddImmediateConstant backend: (riscv) Add canonicalization pattern for AddImmediateConstant Oct 24, 2023
math-fehr
math-fehr approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I'm not sure if the Pure trait was meant for that PR? I'm fine if it is though.

@superlopuh
Copy link
Member Author

It kind of isn't but it feels like a fairly minor change to open another PR for.

@superlopuh superlopuh merged commit 1d5ecd9 into main Oct 24, 2023
10 checks passed
@superlopuh superlopuh deleted the sasha/riscv/more-pure-ops branch October 24, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compor compor compor approved these changes

@math-fehr math-fehr math-fehr approved these changes

@nazavode nazavode Awaiting requested review from nazavode

@AntonLydike AntonLydike Awaiting requested review from AntonLydike

@JosseVanDelm JosseVanDelm Awaiting requested review from JosseVanDelm

@adutilleul adutilleul Awaiting requested review from adutilleul

@alecerio alecerio Awaiting requested review from alecerio

Assignees

@superlopuh superlopuh

Labels
backend Compiler backend in xDSL
Projects
linalg.generic to riscv
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superlopuh @compor @math-fehr