Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arith: Missing fastmath property on arith.cmpf #2725

Closed
zero9178 opened this issue Jun 14, 2024 · 0 comments · Fixed by #3277
Closed

arith: Missing fastmath property on arith.cmpf #2725

zero9178 opened this issue Jun 14, 2024 · 0 comments · Fixed by #3277
Labels
dialects Changes on the dialects

Comments

@zero9178
Copy link
Contributor

Similar to many other floating point operations in arith, arith.cmpf supports specifying relaxations of semantics for code generation and optimizations using the fastmath attribute: https://mlir.llvm.org/docs/Dialects/ArithOps/#attributes-2

This attribute is currently missing from cmpf in xDSL making it impossible to import from generic syntax.
@zero9178 zero9178 added the dialects Changes on the dialects label Jun 14, 2024
@zero9178 zero9178 changed the title arith: Missing fastmath attribute on arith.cmpf arith: Missing fastmath property on arith.cmpf Jun 14, 2024
This was referenced Oct 9, 2024
Closed
Merged
superlopuh added a commit that referenced this issue Oct 23, 2024
@knickish @superlopuh
Arith to riscv lowering fastmath cmpf (#3277)
d67b37d 
`backend`(lowering)-only part of
#3272. Depends on #3275 and
#3276.

This should close #2725 once merged

Co-authored-by: Sasha Lopoukhine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dialects Changes on the dialects
Projects
None yet
Milestone
No milestone
1 participant
@zero9178