Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop opening xdp-dispatcher.o when LIBXDP_SKIP_DISPATCHER=1 is set #418

Closed

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Apr 19, 2024

Even though LIBXDP_SKIP_DISPATCHER=1 is set, it still look for xdp-dispatcher.o and print stderror.

libxdp: Couldn't find a BPF file with name xdp-dispatcher.o
libxdp: Couldn't open BPF file xdp-dispatcher.o

Check the environment variable before opening file.

@ami-GS ami-GS changed the title Fix error message with LIBXDP_SKIP_DISPATCHER=1 Stop opening xdp-dispatcher.o when LIBXDP_SKIP_DISPATCHER=1 is set Apr 19, 2024
@ami-GS ami-GS force-pushed the dev/daiki/fix_skip_dispatcher branch from 7bc93e9 to 62741b2 Compare April 19, 2024 20:35
@tohojo
Copy link
Member

tohojo commented Apr 20, 2024

This will break frags support when the environment variable is set, which is not a good idea. The xdp-dispatcher.o file is still needed even if the dispatcher is not used when loading things into the kernel.

@ami-GS
Copy link
Contributor Author

ami-GS commented Apr 21, 2024

You mean loading xdp-dispatcher.o is required to check capabilities even if LIBXDP_SKIP_DISPATCHER is set? It means that LIBXDP_OBJECT_PATHis also still needed withLIBXDP_SKIP_DISPATCHER`?

@ami-GS ami-GS closed this Apr 21, 2024
@ami-GS ami-GS reopened this Apr 21, 2024
@tohojo
Copy link
Member

tohojo commented Apr 22, 2024 via email

@ami-GS ami-GS closed this Apr 30, 2024
@ami-GS ami-GS deleted the dev/daiki/fix_skip_dispatcher branch April 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants