Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from winapi to windows-sys. #62

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sunfishcode
Copy link
Contributor

This PR migrates dirs-sys-next from winapi to windows-sys.

Windows-sys is actively maintained, by Microsoft, and has recently
started to be adopted in the ecosystem; mio, parking_lot, wasmtime,
and others have moved to windows-sys.

Migrating dirs-sys-next to windows-sys will help me remove one more of
Wasmtime's transitive dependencies on winapi.

This PR migrates dirs-sys-next from winapi to windows-sys.

Windows-sys is actively maintained, by Microsoft, and has recently
started to be adopted in the ecosystem; mio, parking_lot, wasmtime,
and others have moved to windows-sys.

Migrating dirs-sys-next to windows-sys will help me remove one more of
Wasmtime's transitive dependencies on winapi.
This fixes the following clippy error:

```
error: this public function might dereference a raw pointer but is not marked `unsafe`
   --> dirs-sys/src/lib.rs:141:54
    |
141 |             let result = Shell::SHGetKnownFolderPath(folder_id, 0, 0, &mut path_ptr);
    |                                                      ^^^^^^^^^
    |
    = note: `#[deny(clippy::not_unsafe_ptr_arg_deref)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant