Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Disabled TLS certificate check #44

Closed
1 task done
xco-sk opened this issue Oct 27, 2022 · 0 comments · Fixed by #45
Closed
1 task done

Fix code scanning alert - Disabled TLS certificate check #44

xco-sk opened this issue Oct 27, 2022 · 0 comments · Fixed by #45
Assignees
@xco-sk
Labels
bug Something isn't working kibana

Comments

@xco-sk
Copy link
Owner

xco-sk commented Oct 27, 2022 •
edited
Loading

Currently, the Kibana client falls back to InsecureSkipVerify if the certificate is not defined in the config and the URL starts with https://. While this was fine for testing, the production code should raise an exception in such a case, navigating the user to properly configure the certificate used for communication with Kibana.

Tracking issue for:
@xco-sk xco-sk added bug Something isn't working kibana labels Oct 27, 2022
@xco-sk xco-sk self-assigned this Oct 27, 2022
xco-sk pushed a commit that referenced this issue Oct 27, 2022
#44 Fix code scanning alert - Disabled TLS certificate check
f009180
@xco-sk xco-sk linked a pull request Oct 27, 2022 that will close this issue
#44 Fix code scanning alert - Disabled TLS certificate check #45
Merged
xco-sk added a commit that referenced this issue Oct 27, 2022
@xco-sk
Merge pull request #45 from xco-sk/44-fix-code-scanning-alert-disable…
8b8ee1e 
…d-tls-certificate-check

#44 Fix code scanning alert - Disabled TLS certificate check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xco-sk xco-sk

Labels
bug Something isn't working kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#44 Fix code scanning alert - Disabled TLS certificate check xco-sk/eck-custom-resources
1 participant
@xco-sk