Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: Connection test fails #42

Closed
acm-073 opened this issue Oct 27, 2022 · 3 comments · Fixed by #43
Closed

Helm Chart: Connection test fails #42

acm-073 opened this issue Oct 27, 2022 · 3 comments · Fixed by #43
Assignees
Labels
bug Something isn't working deployment

Comments

@acm-073
Copy link

acm-073 commented Oct 27, 2022

Hello,

we use the helm chart to deploy eck-custom-resources, which we find a very helpful piece of software.

However, the connection test in the helm chart has two issues:

  • it should only be enabled if Values.metrics.enabled is true, because otherwise the service that is being tested will not be deployed
  • currently the test makes a request to <service>:8080 which returns a 404. It should rather call <service>:8080/metrics which would return a success HTTP status code.

Would be glad to see these things fixed, because it's quite annoying to have the failed test pod causing an alert each time we deploy the application.

Thanks!
Best regards
Albrecht

@xco-sk
Copy link
Owner

xco-sk commented Oct 27, 2022

Hi @acm-073, thanks for reporting, I will take a look and fix it as soon as possible.

@xco-sk xco-sk added bug Something isn't working deployment labels Oct 27, 2022
@xco-sk xco-sk self-assigned this Oct 27, 2022
xco-sk pushed a commit that referenced this issue Oct 27, 2022
@xco-sk xco-sk linked a pull request Oct 27, 2022 that will close this issue
xco-sk added a commit that referenced this issue Oct 27, 2022
@acm-073
Copy link
Author

acm-073 commented Oct 27, 2022

Just tested, works fine!

Thanks a lot!

@xco-sk
Copy link
Owner

xco-sk commented Oct 27, 2022

Just tested, works fine!

Thanks a lot!

Great to hear that. Thanks again for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants