Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more options to setup BMC port for Dell servers #7469

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

kcgthb
Copy link
Member

@kcgthb kcgthb commented Aug 12, 2024

This PR provides more options to setup BMC/iDRAC port sharing for Dell servers during initial discovery (or later via the bmcsetup postscript).

It extends the usual "0/1" "shared/dedicated" scheme and try to replicate the variety of options available via ipmitool delloem:

       lan set <Mode>
        sets the NIC Selection Mode :
            dedicated, shared with lom<idx>

       lan set <Shared Failover Mode>
        sets the shared Failover Mode :
            shared with failover lom<idx>
            shared with failover all loms,
            shared with failover none.

Since other types of servers already support multiple values in ipmi.bmcport ( f5851bc and 27d8ca5), this PR extends the concept by allowing 3 space-separated values for Dell servers:

  • 1st value: 0 = shared, 1 = dedicated
  • 2nd value: shared LOM index (1-4) (0 or no value means "first available LOM")
  • 3rd value: failover LOM index (1-4) (0 means "no failover", no value means "all LOMs")

To ensure maximum compatibility with the default 0/1 shared/dedicated scheme, the 2nd and 3rd values are optional, and will retain the previous behavior when not specified.

For instance:

ipmi.bmcport BMC interface configuration
0 Shared with first available interface, failover with all LOMs (catch-all mode)
0 1 Shared with LOM1, failover all LOMs
0 1 2 Shared with LOM1, failover LOM2
0 2 0 Shared with LOM2, no failover
1 Dedicated

Add optional values to ipmi.bmcport to support more fine-grained
configuration for Dell servers, and mirror the `ipmitool delloem`
capabilities:

   lan set <Mode>
    sets the NIC Selection Mode :
        dedicated, shared with lom<idx>

   lan set <Shared Failover Mode>
    sets the shared Failover Mode :
        shared with failover lom<idx>
        shared with failover all loms,
        shared with failover none.

This patch introduces the possibility to provide 3 (space-separated)
values for ipmi.bmcport:
  1st value:  0 = shared / 1 = dedicated
  2nd value   shared LOM (1-4)   (0 or no value means first available LOM)
  3rd value:  failover LOM (1-4) (0 means no failover, no value means all LOMs)

To ensure maximum compatibility with the default 0/1 shared/dedicated
scheme, the 2nd and 3rd values are optional, and will retain the
previous behavior when not specified.

Examples:

ipmi.bmcport value      BMC interface configuration
0                       Shared with first available interface, failover with
                        all LOMs (catch-all mode)
0 1                     Shared with LOM1, failover all LOMs
0 1 2                   Shared with LOM1, failover LOM2
0 2 0                   Shared with LOM2, no failover
1                       Dedicated
@Obihoernchen Obihoernchen merged commit d2378d8 into xcat2:master Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants