Preserve CHECK constraints on duplication
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Jan 19, 2024
When duplicating a column for backfilling ensure that any `check` constraints on the original colum are applied to the duplicated column. The `check` constraint is initially created as `NOT VALID` then validated after migration completion.
Ensure that any `CHECK` constraints on columns duplicated for backfilling are validated and renamed when a migration completes.
Ensure that altering a column to make it `NOT NULL` retains any check constraints that were defined on the column.
Ensure that altering a column to add a new `CHECK` constraint preserves existing `CHECK` constraints on the column.
Ensure that adding a foreign key constraint to a column preserves existing `CHECK` constraints on the column.
Ensure that adding a `UNIQUE` constraint to a column preserves existing `CHECK` constraints on the column.
andrew-farries
force-pushed
the
preserve-check-constraints-on-duplication
branch
from
dd65a2f
to
d0dddda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplicating a column for backfilling ensure that any
CHECKconstraints on the original column are re-created on the duplicated column. TheCHECKconstraint is initially created asNOT VALIDthen validated after migration completion.This is part of #227
As of this PR, column properties that are preserved when duplicating a column for backfilling are:
DEFAULTvaluesFOREIGN KEYconstraintsCHECKconstraints