Preserve default on column duplication when changing column type #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
changed the title
andrew-farries
force-pushed
the
preserve-default-on-column-duplication
branch
from
b6cf79d
to
21d7e9c
Compare
andrew-farries
force-pushed
the
preserve-fks-on-change-type
branch
2 times, most recently
from
763db08
to
7f919a0
Compare
andrew-farries
force-pushed
the
preserve-default-on-column-duplication
branch
from
21d7e9c
to
64a3c91
Compare
Check that changing a column's type preserves a default value defined on the column.
andrew-farries
force-pushed
the
preserve-default-on-column-duplication
branch
from
64a3c91
to
2838f67
Compare
exekias
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplicating a column for backfilling to change a column's type, ensure that any default on the column is preserved on the duplicated column.
This fixes the issue where changing type would lose any
DEFAULTdefined on the columnThis is part of a larger class of issues where duplicated columns are not faithfully preserving all properties of the original, tracked in #227.