-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecosystem section #123
Ecosystem section #123
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @TomNicholas !
I'm happy to present all this content in person on the day, but I think it would be much quicker if one of you guys added the section on rioxarray.
Sounds good. Feel free to leave a blank cell and I'll follow up after this is merged with a tiny example.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I think this is basically ready to merge, just the rioxarray section missing (plus how did you get your exercises to be in drop-down boxes?) |
would be good to normalize exercise formatting across notebooks (#88), for now if you want a dropdown on the rendered version you add |
looks great @TomNicholas, just need to |
for more information, see https://pre-commit.ci
Okay great @scottyhq - I've added an |
Should I be worried about the build-and-deploy test failing? |
Oh, right, you can see the traceback in the 'Dump build logs' step:
If you add a @dcherian what do you think of adding a branch protection rule to require that test to pass before merging? i don't have that admin access it seems |
This comment was marked as duplicate.
This comment was marked as duplicate.
Just enabled! |
for more information, see https://pre-commit.ci
@@ -10,26 +10,126 @@ | |||
"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. import cf_xarray.units # must be imported before pint_xarray
the import order is not important anymore with recent versions of pint
, so you should probably remove the comment
Reply via ReviewNB
Intended to fill part of the Ecosystem section of the xarray scipy tutorial, so addressing #116.
Planning to have a short bit of material on each of these topics:
Currently a work-in-progress.@dcherian @scottyhq I'm planning to try and write the hvplot, pint-xarray, and possibly cf-xarray sections now, but I'm really not at all familiar with rioxarray (I've never even imported it 😅). I'm happy to present all this content in person on the day, but I think it would be much quicker if one of you guys added the section on rioxarray.