CP-40716: update usages of third-party libraries#4786
Merged
Conversation
psafont
force-pushed
the
private/paus/refresh
branch
from
5d0219a to
63c66b5
Compare
edwintorok
approved these changes
Sep 13, 2022
Member
edwintorok
left a comment
edwintorok
left a comment
There was a problem hiding this comment.
LGTM they are mostly name changes to use the new APIs.
One minor comment about the use of try+match+with+with (although that wasn't introduced by this PR).
Also not sure about the lazy default context, but as long as the tests pass I think it'll be fine.
Member
Author
|
robhoes
approved these changes
Sep 14, 2022
psafont
force-pushed
the
private/paus/refresh
branch
2 times, most recently
from
c6a3218 to
af26915
Compare
psafont
changed the title
psafont
force-pushed
the
private/paus/refresh
branch
3 times, most recently
from
6a70cf4 to
c60251e
Compare
psafont
force-pushed
the
private/paus/refresh
branch
from
c60251e to
f72ea48
Compare
lindig
approved these changes
Nov 4, 2022
psafont
force-pushed
the
private/paus/refresh
branch
3 times, most recently
from
66a9e9d to
ce18e56
Compare
psafont
force-pushed
the
private/paus/refresh
branch
from
ce18e56 to
3d7a72a
Compare
psafont
force-pushed
the
private/paus/refresh
branch
3 times, most recently
from
c147f7d to
efe5654
Compare
psafont
force-pushed
the
private/paus/refresh
branch
from
efe5654 to
752b601
Compare
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Now keys using elliptical curve cryptography need to be taken into account. Keep the same behaviour as previously by rejecting them Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
The context is now is lazy-loaded, so force it's loading. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Now io-page is compiled using dune and it's not split into two. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
psafont
force-pushed
the
private/paus/refresh
branch
from
752b601 to
1595525
Compare
Makes it easier to spot which call failed this check when triaging related issues Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
psafont
force-pushed
the
private/paus/refresh
branch
from
1595525 to
52bf935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts code to new versions introduced by xapi-project/xs-opam#610
fixes #4686