Fix compiler warnings#31
Conversation
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
| Lwt.catch | ||
| (fun () -> Lwt_unix.mkdir vbd_list_dir 0o755) | ||
| (function | ||
| | Unix.(Unix_error (EEXIST, "mkdir", dir)) when dir = vbd_list_dir -> Lwt.return_unit |
There was a problem hiding this comment.
Is it just a compiler bug that it's moaning about this open?
There was a problem hiding this comment.
Maybe, I found this very puzzling. Maybe I should undo this change.
There was a problem hiding this comment.
Because the EEXIST variant is actually in the Unix module.
There was a problem hiding this comment.
This is the bug that's affecting xcp-idl too - I've had to do precisely this change there. Quite annoying actually.
There was a problem hiding this comment.
Don't despair... we will be able to move to 4.06.? soon ;)
There was a problem hiding this comment.
So that means this PR is good to go then? :)
|
The Travis failure is due to |
xenctrl currently doesn't build in Debian 9 Stretch. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
|
I don't understand why now it does not find It must be something to do with other packages |
|
I'm looking into it, it's an issue with the docker script: |
|
Opened ocaml/ocaml-ci-scripts#222 t ofix the Travis issue. |
Signed-off-by: Gabor Igloi gabor.igloi@citrix.com