Skip to content

Fix compiler warnings#31

Merged
gaborigloi merged 2 commits into
xapi-project:masterfrom
gaborigloi:warn
Mar 19, 2018
Merged

Fix compiler warnings#31
gaborigloi merged 2 commits into
xapi-project:masterfrom
gaborigloi:warn

Conversation

@gaborigloi
Copy link
Copy Markdown
Contributor

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Comment thread lib/vbd_store.ml
Lwt.catch
(fun () -> Lwt_unix.mkdir vbd_list_dir 0o755)
(function
| Unix.(Unix_error (EEXIST, "mkdir", dir)) when dir = vbd_list_dir -> Lwt.return_unit
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just a compiler bug that it's moaning about this open?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I found this very puzzling. Maybe I should undo this change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the EEXIST variant is actually in the Unix module.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bug that's affecting xcp-idl too - I've had to do precisely this change there. Quite annoying actually.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't despair... we will be able to move to 4.06.? soon ;)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that means this PR is good to go then? :)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so

@gaborigloi
Copy link
Copy Markdown
Contributor Author

The Travis failure is due to xenctrl :( xapi-project/ocaml-xen-lowlevel-libs#106
I'll switch it to CentOS

xenctrl currently doesn't build in Debian 9 Stretch.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Mar 16, 2018

I don't understand why now it does not find xen-api-client-lwt, it is there: https://github.com/xapi-project/xs-opam/tree/master/packages/xs-extra/xen-api-client-lwt.master

It must be something to do with other packages

@gaborigloi
Copy link
Copy Markdown
Contributor Author

I'm looking into it, it's an issue with the docker script:

Step 3/11 : RUN bash -eux -c 'git remote set-url origin git://github.com/xapi-project/xs-opam && git fetch origin master && git reset --hard origin/master'
 ---> Running in b598d9e7436b

+ git remote set-url origin git://github.com/xapi-project/xs-opam
+ git fetch origin master



warning: no common commits
From git://github.com/xapi-project/xs-opam
 * branch            master     -> FETCH_HEAD
+ git reset --hard origin/master
Checking out files: 100% (25038/25038), done.

@gaborigloi
Copy link
Copy Markdown
Contributor Author

Opened ocaml/ocaml-ci-scripts#222 t ofix the Travis issue.

@gaborigloi gaborigloi merged commit b0ae20e into xapi-project:master Mar 19, 2018
@gaborigloi gaborigloi deleted the warn branch March 19, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants