Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select formula from a list of user formulas #200

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

kanurag94
Copy link
Member

Type: Enhancement
Fixes #123

Added option to select formula from a list of user formulas.

  1. New formulas can be saved using the Add button, cursor will automatically point to new formula once it is added.
  2. Existing formulas can also be selected and deleted using the Delete button.
  3. Click OK after selecting formula, to apply formula to the fractal.
  4. Currently used formula is populated every time dialog box is opened automatically.

Where to find?
Fractal -> Saved user Formulas

Screenshot

Screenshot from 2020-08-17 23-17-02

Further Info:
DIALOG_ILIST type dialog can be reused to create such dialog boxes again. This will be helpful in multiple scenarios. Just put a check for label name and save the list there.

@kanurag94 kanurag94 requested a review from kovzol August 17, 2020 18:30
@kovzol kovzol merged commit b3b0301 into xaos-project:master Aug 17, 2020
@kanurag94 kanurag94 deleted the userformula branch August 17, 2020 18:58
@kovzol
Copy link
Contributor

kovzol commented Aug 19, 2020

I like the new feature, thanks for the improvement!
Maybe it would be even better if there was no new option for that, but this could be added to the menu User formula..., and an editable combobox could show the current formula, and a list of the former formulas could be shown when opening the list with the arrow icon. In this way there would be no option to remove a formula, but the interface would be more intuitive. Actually, if a user finds a nice formula, he/she will save it as an .xpf file. So there is no need to maintain a big database of formulas, only the last couple of entries should be shown for the user's convenience.

@kanurag94
Copy link
Member Author

So something like this? with upto 10 historical data? and drop down list openable by arrow icon?
rsz_1drawing

@kovzol
Copy link
Contributor

kovzol commented Aug 19, 2020

No, with only one input field. Similarly to the URL input field in most browsers.

@kanurag94
Copy link
Member Author

Screenshot from 2020-08-19 16-32-17
Maybe this?

@kovzol
Copy link
Contributor

kovzol commented Aug 19, 2020

Yes---I guess the input field is editable. ;-)

@kanurag94
Copy link
Member Author

kanurag94 commented Aug 19, 2020

Updated #202 with the changes :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selecting from a list of user formulas
2 participants