Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current fractal information help menu #198

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

kanurag94
Copy link
Member

Fixes #164

Added: Help -> Info on current fractal opens up the wiki for the current fractal at https://github.com/xaos-project/XaoS/wiki/Fractal-Types

@kanurag94 kanurag94 requested a review from kovzol August 16, 2020 07:23
@kovzol kovzol merged commit 9a588c2 into xaos-project:master Aug 16, 2020
@kovzol
Copy link
Contributor

kovzol commented Aug 16, 2020

Thanks, the change is nice. I have some minor suggestions:

@kanurag94
Copy link
Member Author

I have addressed these in f01fad8
I would manually change the url for others once you update the wiki. :D

@kovzol
Copy link
Contributor

kovzol commented Aug 16, 2020

Thanks!

@kovzol
Copy link
Contributor

kovzol commented Aug 17, 2020

I updated the wiki. Some fractals would need more information, but as a first step I think now it's OK.
I am not completely satisfied with the fractal names in XaoS. E.g. "S.Carpet" looks ugly, instead of that "Sierpinski Carpet" should be used. Please, could you check why S.Carpet is given there? Also, I am unsure why "Sym. Barnsley" is used instead of "Symmetric Barnsley". Maybe it would be better to use "Sierpinski Triangle" instead of "Sierpinski" and "Spidron Hornflake" instead of "Spidron hornflake" (unifying capitalization).
What do you think?

@kovzol
Copy link
Contributor

kovzol commented Aug 17, 2020

And maybe we can unify Octo/Octal. I am unsure which one should be used.

@kanurag94
Copy link
Member Author

All these are short names and abbreviations used for the names. They can be very well renamed with proper names and capitalization.
I think we should use Octo instead of Octal. Octal does not make much sense unless we say Octal Mandelbrot.

@kanurag94 kanurag94 deleted the fractalhelp branch August 17, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting a Fractal should show formula
2 participants