Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify open/ open image and save/ save image #191

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

kanurag94
Copy link
Member

Issue #190

This PR unifies Open and Open Image menu options. Now Open is able to load png and xpf both.
Save Image has been shifted to Save as and Save remains as it is.

Screenshot from 2020-07-21 13-14-40
Save as should get populated in future when xaos starts supporting more export formats.

Ps. Should we rename Save as to Export as ?

@kanurag94 kanurag94 requested a review from kovzol July 21, 2020 07:48
@kovzol kovzol merged commit 8e1ad7b into xaos-project:master Jul 21, 2020
@kovzol
Copy link
Contributor

kovzol commented Jul 21, 2020

I think Export... can be even better.

@kanurag94
Copy link
Member Author

I gave this some thought. It seems that save is usually associated as a term for saving files to format that program can reuse. In this case PNGs are reusable by xaos. Export is kind of a conversion option to some other format. I think save as is somewhat self explanatory to users.

Ps. In between export and export as - Export... is good.

@kovzol
Copy link
Contributor

kovzol commented Jul 21, 2020

Yes, you're right. That's fine then.

@kanurag94 kanurag94 deleted the unify_open_save branch July 22, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants