Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rendering #186

Merged
merged 6 commits into from
Jul 9, 2020
Merged

Improve Rendering #186

merged 6 commits into from
Jul 9, 2020

Conversation

kanurag94
Copy link
Member

After #184 , there were some changes regarding batch rendering

The patch basically works well, but I found the following issues:
It seems that displayed messages can be mixed between animations.
The naming would be better to be related with the original filenames and not the selection number.
If this patch works correctly, we no longer need the Render... menu. But instead of removing it, I suggest we use the Render... menu and allow selection of multiple files in that menu.

These are addressed in this PR

@kanurag94 kanurag94 requested a review from kovzol July 9, 2020 10:28
@kovzol kovzol merged commit d4008f0 into xaos-project:master Jul 9, 2020
@kovzol
Copy link
Contributor

kovzol commented Jul 9, 2020

I like this new version. However I am unsure what the correct way would be to define the filenames.
Now it is something like anim_%s_%06d.png where anim is the basename, %s is the filename (without extension) and %06d is the frame number, padded to 6 digits. Maybe our users want to set this on their own.
Other software tools have similar traditions, see e.g. https://stackoverflow.com/questions/10957412/fastest-way-to-extract-frames-using-ffmpeg, for example ffmpeg allows defining the pattern with something like $filename%03d.bmp.
Let's discuss this question here.

@kanurag94
Copy link
Member Author

I think it's a good idea to let users define their own pattern for file generation. However letting the user define %06d part is not foolproof. For a new user it's difficult to know how many frames their animation file might take.
The rendered images could be overwritten if a user provides a pattern without filename. A pattern like basename_%s_%xD.png where %s is the filename and x is user definable could be a better alternative. I would like the basename functionality to remain since I might be tagging the rendered images by my own signature for example march_dragon_01.png

@kovzol
Copy link
Contributor

kovzol commented Jul 9, 2020

Yes, we must be careful here. Our users include non-experts. But we can, of course, add a Help button here, and define a good default entry.
For the moment the current behavior is acceptable. Maybe for a future version someday we will have a good idea for an improvement.
In fact, if a user selects fract1.xpf and fract1.xaf, the result is something mixed. Maybe we still want to keep the extension in the filenames in some form...

@kanurag94
Copy link
Member Author

kanurag94 commented Jul 9, 2020

In fact, if a user selects fract1.xpf and fract1.xaf, the result is something mixed. Maybe we still want to keep the extension in the filenames in some form...

Yes and some of the users may name their file with common names for example "untitled.xpf" again and again and end up overwriting their previously rendered images. This is problematic. That's why I was previously using filenumber in #184 but that is still not enough. We need to give some warning when this occurs.

@kanurag94 kanurag94 deleted the batchrender branch July 22, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants