Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gradient to Custom palette #168

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

kanurag94
Copy link
Member

@kanurag94 kanurag94 commented Jun 18, 2020

Type: Enhancement
Part of #165

What's new?
This PR will add feature for users to know beforehand the color palette going to be generated.

Where to see changes?
In GUI menu, Fractal->Palette->Custom Palette

Screenshot from 2020-06-18 13-40-34

@kanurag94 kanurag94 requested a review from kovzol June 18, 2020 08:29
@kovzol kovzol merged commit ee609b6 into xaos-project:master Jun 18, 2020
@kovzol
Copy link
Contributor

kovzol commented Jun 18, 2020

I like this change!
I think that the current behavior should be however simplified by removing the upper part of the window. Currently the new values seem to be some random numbers. What if the old values are just copied to these input boxes (below)? The user can still press Cancel if the color schema is not the expected one.

@kanurag94
Copy link
Member Author

Currently the new values seem to be some random numbers.

They are the last fed values/ current values already.

The user can still press Cancel if the color schema is not the expected one.

I agree, though I thought if a user wanted to see the difference most importantly in shift values, they would be interested in reading minute changes from previous shift values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants