Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Buffer Overflow issue #156

Merged
merged 2 commits into from
May 16, 2020
Merged

Fix Buffer Overflow issue #156

merged 2 commits into from
May 16, 2020

Conversation

kanurag94
Copy link
Member

Fixes #152

This PR changes the size of buffer for filenames, this fixes the persisting issue.

@kanurag94 kanurag94 requested a review from kovzol May 16, 2020 09:40
@kovzol
Copy link
Contributor

kovzol commented May 16, 2020

Is this a hotfix that works below 80 characters only? If so, we should find a long term solution that is independent of the length.

@kanurag94
Copy link
Member Author

kanurag94 commented May 16, 2020

Yes, but we don't have filenames above 80 characters right now.

Though, I'll try if we can have a solution independent of length.

@kovzol
Copy link
Contributor

kovzol commented May 16, 2020

Do you mean the filenames are without full path here?

@kanurag94
Copy link
Member Author

Do you mean the filenames are without full path here?

My mistake. The filenames are complete paths. I will work on a dynamic solution

@kovzol kovzol merged commit f4c96c4 into xaos-project:master May 16, 2020
@kovzol
Copy link
Contributor

kovzol commented May 16, 2020

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XaoS crashes on recording XaoS animations from examples
2 participants