Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use temporarily an XPF file when saving/loading from a PNG #179

Closed
kovzol opened this issue Jun 30, 2020 · 0 comments · Fixed by #180
Closed

Do not use temporarily an XPF file when saving/loading from a PNG #179

kovzol opened this issue Jun 30, 2020 · 0 comments · Fixed by #180
Assignees
@kanurag94
Labels
enhancement

Comments

@kovzol
Copy link
Contributor

kovzol commented Jun 30, 2020

Writing a temporary file is not elegant. It is a kind of overkill. Instead, the XPF should be stored in memory.
@kanurag94 kanurag94 self-assigned this Jul 1, 2020
@kanurag94 kanurag94 mentioned this issue Jul 1, 2020
Merged
@kovzol kovzol changed the title Do not use temporary an XPF file when saving/loading from a PNG Do not use temporarily an XPF file when saving/loading from a PNG Jul 1, 2020
kovzol added a commit that referenced this issue Jul 1, 2020
@kovzol
addendum to fix #179 (Windows)
56aca37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanurag94 kanurag94

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use temporarily an XPF file when saving/loading from a PNG kanurag94/XaoS
2 participants
@kovzol @kanurag94