Add expires_at field when creating project deploy keys #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
Nov 4, 2024
deploy_keys.go
Outdated
| Key *string `url:"key,omitempty" json:"key,omitempty"` | ||
| Title *string `url:"title,omitempty" json:"title,omitempty"` | ||
| CanPush *bool `url:"can_push,omitempty" json:"can_push,omitempty"` | ||
| ExpiresAt *ISOTime `url:"expires_at,omitempty" json:"expires_at,omitempty"` |
There was a problem hiding this comment.
ISOTime is actually only used for parts where only the data is required (in hindsight it should have been called ISODate I guess). So this needs to be:
Suggested change
| ExpiresAt *ISOTime `url:"expires_at,omitempty" json:"expires_at,omitempty"` | |
| ExpiresAt *time.Time `url:"expires_at,omitempty" json:"expires_at,omitempty"` |
svanharmelen
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2020
The code in this area was a bit confusing. There are two similar endpoints:
The code linked to the documentation for the first one and was named like it was the first one, but it was actually the second one.
I've updated the documentation link, but adding support for the first one will be difficult in future given it's name is already taken.