member role model follow 17.4.0 spec #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, ManageDeployToken, ManageMergeRequestSettings, ManageSecurityPolicyLink, ReadRunners, RemoveGroup to MemberRoles struct to comply with 17.4.0 spec
…Members AdminPushRules AdminTerraformState AdminWebHook ArchiveProject ManageDeployTokens ManageGroupAccesToken ManageMergeRequestSettings ManageProjectAccessToken ManageSecurityPolicyLink ReadRunners RemoveGroup RemoveProject to CreateMemberRoleOptions to align with 17.4.0 spec
Quanalogy
force-pushed
the
feature/member_role_model_follow_17_4_0_spec
branch
from
5172bbe
to
3869a51
Compare
svanharmelen
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition of creating and listing member roles were not up to date with the current api.
I've added all currently defined elements per the api spec, updated test data and simplified the tests a bit.