Add TriggerTestProjectHook function to ProjectsService #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
Jul 12, 2024
projects.go
Outdated
Comment on lines
1433
to
1437
| // In GitLab 17.0 and later, this endpoint has a special rate limit. | ||
| // In GitLab 17.0 the rate was three requests per minute for each project hook. | ||
| // In GitLab 17.1 this was changed to five requests per minute for each project and authenticated user. | ||
| // To disable this limit on self-managed GitLab and GitLab Dedicated, | ||
| // an administrator can disable the feature flag named web_hook_test_api_endpoint_rate_limit. |
There was a problem hiding this comment.
Suggested change
| // In GitLab 17.0 and later, this endpoint has a special rate limit. | |
| // In GitLab 17.0 the rate was three requests per minute for each project hook. | |
| // In GitLab 17.1 this was changed to five requests per minute for each project and authenticated user. | |
| // To disable this limit on self-managed GitLab and GitLab Dedicated, | |
| // an administrator can disable the feature flag named web_hook_test_api_endpoint_rate_limit. | |
| // In GitLab 17.0 and later, this endpoint has a special rate limit. | |
| // In GitLab 17.0 the rate was three requests per minute for each project hook. | |
| // In GitLab 17.1 this was changed to five requests per minute for each project | |
| // and authenticated user. | |
| // | |
| // To disable this limit on self-managed GitLab and GitLab Dedicated, an | |
| // administrator can disable the feature flag named web_hook_test_api_endpoint_rate_limit. |
projects.go
Outdated
| ProjectHookEventReleases ProjectHookEvent = "releases_events" | ||
| ProjectHookEventEmoji ProjectHookEvent = "emoji_events" | ||
| ProjectHookEventResourceAccessToken ProjectHookEvent = "resource_access_token_events" | ||
| ) |
There was a problem hiding this comment.
Can you move this to (the correct ordered location) in types.go? Thanks!
|
Hi, thanks for your comment, I changed as your suggestion. |
|
Do you have any updates on its release schedule? |
|
Released |
|
Thank you very much. I truly appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From GitLab 17.0+ they add "Trigger a test project hook" to test project's hook