Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Pass the Optimize flags from the extra bundler arguments to the linker configuration. #9599

Merged

Commits on Sep 8, 2020

  1. [dotnet] Pass the Optimize flags from the extra bundler arguments to …

    …the linker configuration.
    
    Also call Application.InitializeCommon to initialize the application instance. The
    important part here is that InitializeCommon calls Optimizations.Initialize to compute
    the default optimizations. It also calls Set*ExceptionMode and sets the default EnableCoopGC
    value (so we don't need to call/set those anymore), and it does a few other initialization
    tasks which we don't need yet, but eventually will.
    
    And finally remember to parse the bundler arguments before using them in the dotnet
    build logic. How did this not cause problems before? 🤦
    rolfbjarne committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3a8040e View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. [tests] Set the verbosity using the additional args instead of an int…

    …ernal variable.
    
    The internal _BundlerVerbosity variable is overwritten now (with the verbosity
    value from the additional args).
    rolfbjarne committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    dcc1750 View commit details
    Browse the repository at this point in the history
  2. [xharness] Disable tvOS generation for the introspection/.NET test, i…

    …t incorrect and needs fixing.
    rolfbjarne committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    8a7833f View commit details
    Browse the repository at this point in the history